plan-readability-prs-10-12.md 1.7 KB

Plan: readability PRs 10-12 (R2-R7)

Branch: plan-readability → main

What changed

docs/review-fixes-plan.md plans the review's readability findings as three PRs. None changes behaviour or the version.

  • PR 10 go-readability (R3 in Go, R4, R5, R6): split state(), rename the two wraps and two edits, break up main() and the CLI's init(), two maps instead of "\x00" keys in uniqueFile, a comment on the NaN-safe BPM check.
  • PR 11 frontend-format (R2, R3 in Svelte): Prettier with the Svelte plugin, printWidth 120, format and format:check scripts, the reformat in its own commit, then clearer names in SequencePanel.svelte.
  • PR 12 shared-modal (R7): one Modal.svelte for About, Confirm and Move/Copy to pad, with a table of each dialog's role, Escape, click-outside and focus behaviour to keep.
  • "No behaviour change" checks for all three: tests pass unchanged apart from renames, a DemoFile export is byte-identical before and after, TestBoundMethods and the bindings are untouched, and a laptop walk-through of both tabs and every dialog.
  • Decisions (user, 2026-11-13): Prettier and its plugin approved as dev dependencies; no version bump for these PRs; S5, M9, M10 and M11 skipped for now.
  • Checks before every push now set GOTOOLCHAIN=go1.27.4 and, from PR 11 on, run npm run format:check.
  • The Backlog keeps only S5, M9, M10 and M11.

The plan's R6 list drops the serveAudio item: since PR 6 it reads the source through Source() and is safe as written.

No code changes.

Testing

Documentation only. Checked against main (c436348): 8 frontend lines over 160 characters (longest 250), main() 95 lines, the CLI's init() 103 lines, and the other R3-R7 code still as described.