Página inicial Explorar Ajuda
Entrar
bajdev
/
mpckit
1
0
Fork 0
Arquivos Pull Requests 1
Tree: f99f652c05
Branches Tags
mpckit
/
pull-requests
/
m8-load-guard-rails
/
m8-load-and-guard-rails.md

m8-load-and-guard-rails.md 3.0 KB
Histórico Raw

M8: load and guard rails

Branch: m8-load-guard-rails → main

Load itself, the unsaved-changes prompt on New and Load, the overwrite confirmation and Go's error messages for bad WAVs and limits came in M5–M7. This PR adds the rest of M8 and the checklist for device checkpoint B.

What changed

  • Missing sample files. A loaded project's samples are expected in its _[ProjectData] folder, and a sample assigned from elsewhere can be moved or deleted later. The state now says, per pad, where the sample comes from and whether that file still exists.
    • The grid shows missing (in red) on such pads.
    • The pad panel shows the expected path and says to replace the sample or put the file back and load again. Play is disabled.
    • The footer counts missing files.
    • Export refuses and lists every missing file, as since M3, and writes nothing.
    • Replacing the sample clears the warning.
  • Closing the window with unsaved changes. A Go hook stops the close and sends a close event. The app asks "Close without exporting?"; Close discards the changes and quits, Cancel stays. Without unsaved changes the window closes straight away.
  • Device checkpoint B checklist (docs/checkpoint-b.md, linked from the build plan). Five projects (MpckitB1–B5), each made from DemoFile in the app: no changes, moving a pad with notes, copying across banks and swapping pads with notes, removing the current sequence and adding one in bank B, and shortening a sequence with notes. Each lists what to listen for, plus an empty results table. It also covers open question 7 (currentSequence) and B5 (notes past a new end).
  • Go service: CloseWindow for the frontend. Dirty and SetCloser are for main.go only and kept out of the bindings.

Testing

On the server: go vet and go test ./... pass. New tests:

  • Missing files: load a copy of DemoFile with one sample deleted. The count is 1 and the right pad is marked (no preview URL, source path set). Export fails naming the file and writes nothing. After replacing the sample, the count is 0 and export works.
  • Close: CloseWindow calls the closer, and Dirty follows edits.

The frontend is untested here (no Node). On the laptop:

  1. npm run check in frontend: 0 errors, 0 warnings.
  2. Missing file: copy DemoFile.xpj and its DemoFile_[ProjectData] folder somewhere, delete 80s-Snr-Dreamer SA.wav from the copy, and Load it. A02 shows missing, the footer says 1 sample file missing, A02's panel shows the path, and Play is disabled. Export reports the missing file. Replace A02 with any WAV: the warning goes and export works.
  3. Close: make any change and close the window. The app asks; Cancel stays open. Close again and choose Close: the app quits. With no changes (or right after exporting) the window closes without asking.
  4. Checkpoint B (M8 done-when): build the five projects in docs/checkpoint-b.md, try them on the device, and send me the results. I'll record them in the format doc and build plan.