mpckit/pull-requests/plan-assign-names/add-assign-name-check-to-pr-3.md

Plan: check new sample file names at assign (PR 3)

Branch: plan-assign-names → main

What changed

docs/review-fixes-plan.md, PR 3 (safe-export) gets one more task and done criterion.

Found while checking PR 1: AssignSample names a new pool file after the WAV's own file name. On Linux or macOS a file can be called kick\one.wav; MPCkit accepts and exports it, and loading that export fails PR 1's check (samples[0].path: file name "kick\\one.wav" contains a folder separator). On Windows and on the device's card the backslash would also read as a folder separator.

• Task: in AssignSample, clean the new pool file name so it passes PlainFileName: /, \ and control characters become _, and an empty, . or .. result becomes sample.wav.
• Done when: assigning kick\one.wav gives kick_one.wav, and the exported project loads again.
• The PR table now lists PR 3 as "S1 (export side and assign)".

No code changes.

Notes

Merge this before the PR 3 agent starts. It does not affect PR 2.

Testing

Documentation only. Reproduced the problem with mpckit-cli on main (89e2955): -pad 'A1=kick\one.wav' exports, and -load of that export fails as above.